Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set plugin priority, fixes #350 #803

Merged
merged 6 commits into from
Jun 9, 2020
Merged

set plugin priority, fixes #350 #803

merged 6 commits into from
Jun 9, 2020

Conversation

mkalkbrenner
Copy link
Member

see #755
see #756

@codecov-commenter
Copy link

codecov-commenter commented Jun 6, 2020

Codecov Report

Merging #803 into master will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #803      +/-   ##
============================================
- Coverage     90.63%   90.59%   -0.05%     
  Complexity     3528     3528              
============================================
  Files           304      304              
  Lines          7624     7623       -1     
============================================
- Hits           6910     6906       -4     
- Misses          714      717       +3     
Flag Coverage Δ Complexity Δ
#unittests 90.59% <100.00%> (-0.05%) 3528.00 <6.00> (ø)
Impacted Files Coverage Δ Complexity Δ
src/Plugin/CustomizeRequest/CustomizeRequest.php 100.00% <100.00%> (ø) 31.00 <6.00> (ø)
src/Plugin/Loadbalancer/Loadbalancer.php 100.00% <100.00%> (ø) 52.00 <0.00> (ø)
src/Plugin/PostBigRequest.php 100.00% <100.00%> (ø) 8.00 <0.00> (ø)
src/Core/Event/PreExecuteRequest.php 80.00% <0.00%> (-20.00%) 7.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31bdf7b...0ddff59. Read the comment docs.

Markus Kalkbrenner added 2 commits June 6, 2020 20:32
Copy link
Collaborator

@wickedOne wickedOne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, this fixes the issue for whoever uses the PostBigRequest combined with the CustomizeRequest / LoadBalancer in conjunction with the symfony event dispatcher (which would be the vast majority). 👍

nevertheless a mention in the documentation about in which order of the plugins should be registered would be a good addition for those using another dispatcher i think.

@mkalkbrenner mkalkbrenner merged commit be4a9fd into master Jun 9, 2020
@mkalkbrenner mkalkbrenner deleted the plugin_priority branch June 9, 2020 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants