Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

color variable names confusing #5

Closed
alecbz opened this issue Feb 3, 2015 · 1 comment · Fixed by #6
Closed

color variable names confusing #5

alecbz opened this issue Feb 3, 2015 · 1 comment · Fixed by #6

Comments

@alecbz
Copy link

alecbz commented Feb 3, 2015

The naming of the variables seems a little bit confusing. For instance: in dark mode, we have #define S_base03 #002b36, and in light mode, we have #define S_base03 #fdf6e3.

But if we look at the solarized values table on the main site, we see base03 #002b36.

So the entry for the light mode is sort of incorrect.

I think this is done just so that in the common code we can have *background: S_base03 work for either light or dark, but it seems like it would be better to have the light and dark sections each name their own background variable, instead of changing the value of base03, which should be constant across both schemes (just used in different ways).

@blueyed
Copy link
Contributor

blueyed commented Apr 9, 2015

👍

See also altercation/solarized#68

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants