Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add light/dark conditional to Xresources #68

Closed
wants to merge 1 commit into from

Conversation

dgoodlad
Copy link

This is split from #49, and improved slightly.

The choice between themes is made by defining either SOLARIZED_LIGHT
or SOLARIZED_DARK.
@lkraav
Copy link

lkraav commented Apr 23, 2011

something seems to be wrong with this. doing set background in vim seems to be in exact reverse, light gives me dark background and vice versa. xterm itself behaves correctly.

@blueyed
Copy link

blueyed commented Apr 25, 2011

It is not working in Vim for me correctly, too.

http://i.imgur.com/vvlfN.png

Is this related to this comment/missing fix? #49 (comment)

My whole ~/.Xdefaults file is available here: http://pastebin.com/raw.php?i=kZiuEwRb

@lkraav
Copy link

lkraav commented Aug 26, 2011

regarding #140, i've discovered taht flipping #defines is not enough, you also need to flip color definitions for xresources light to work properly. otherwise for example vim (and probably others) will for example think that you always have dark background color.

lkraav/dotfiles@2b0b536

not sure if altercation has any time for this project anymore. would love to hear from other solarized xresources users. imho solarized light combined with xcalib -invert for night time is the best combo there is.

one thing i dont understand regarding this is altercation's comment #49 (comment). why would light mode foreground color have to be flipped? if i flip both *foreground and *background after flipping #defines, it will just revert back to dark mode.

@TrevorBramble
Copy link
Collaborator

We have an experimental dynamic loading method that doesn't seem to awkward or fragile. But for now flip-flopping dark/light can be done by swapping commented sections.

blueyed added a commit to blueyed/xresources that referenced this pull request Apr 9, 2015
This is adopted from altercation/solarized#68,
but without the "rebasing" / intermediate definitions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants