Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for arm (Raspberry pi's ARM here) architecture #234

Merged
merged 2 commits into from
Mar 8, 2016

Conversation

gibre
Copy link

@gibre gibre commented Feb 28, 2016

Available since 0.6.0 on the mirror used in the module (https://releases.hashicorp.com/consul/)

@solarkennedy
Copy link
Contributor

Cool. Do you know if you can regex it and do ^arm? I don't want to get into the business of enumerating all the arm arch's and I be they cross compile the consul binary for many of them.

@gibre
Copy link
Author

gibre commented Mar 7, 2016

Yeah good idea, indeed, enumerating all arm architectures is not really efficient :). It's done.

@EvanKrall
Copy link
Contributor

arm64, armel, armhf are not necessarily compatible.

@solarkennedy
Copy link
Contributor

@EvanKrall Hmmm. Here is a file on the binary:

consul: ELF 32-bit LSB executable, ARM, EABI5 version 1 (SYSV), statically linked, not stripped

I don't know how nuts we have to be about this. I'll take a second opinion, should we just glob arm and leave it up to the user to know their own hardware? Or is there a sane regex we can do to capture the arches we want but not the other ones? (my vote is for the glob)

@hopperd
Copy link
Contributor

hopperd commented Mar 8, 2016

I'd say glob it, let a future pull request from somebody that might provide a better regex improve it if needed.

solarkennedy added a commit that referenced this pull request Mar 8, 2016
add support for arm (Raspberry pi's ARM here) architecture
@solarkennedy solarkennedy merged commit ed4e6b1 into voxpupuli:master Mar 8, 2016
@solarkennedy
Copy link
Contributor

Globbed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants