More Systemd unit file improvements #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since Consul 0.7, client-mode agents are shutting down gracefully by default, so no need to send them a SIGINT specially. The default for server-mode agents is still not to leave gracefully on SIGTERM, but it was left this way for a reason. To override this, it is better to set the leave_on_terminate option, rather than changing the KillSignal.
Let a human shut the agent down manually with a kill signal.
amiryal
force-pushed
the
systemd_unit_cleanup
branch
from
d1059d0
to
e3442d2
Compare
spuder
pushed a commit
to spuder/puppet-consul
that referenced
this pull request
Feb 25, 2020
More Systemd unit file improvements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the merge of #301, I learned some more about Consul’s defaults, and I also stumbled upon an example systemd.service file inside the official consul repository.
In the example unit file, the option is set to
Restart=on-failure, so I decided to align with that, and let a human operator shut the agent down manually with a kill signal, rather than having to always usesystemctlfor that.The reason for changing
KillSignalback to its defaultSIGTERMis explained in #282 (comment) – in short, it prevents admins from shooting themselves in the foot by unintentionally altering quorum size on server termination. Thanks to Consul developer Armon Dadgar for highlighting the issue.