Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config_defaults hash parameter #54

Merged
merged 1 commit into from
Dec 8, 2014

Conversation

michaeltchapman
Copy link
Contributor

Allow sites to specify a baseline set of config items to be applied to
all nodes via config_defaults that can be overridden via hash
merge with config_hash. This doesn't change the current behavior
for users, but allows users running both agents and servers
to consolidate defaults for both roles in a single key instead
of repeating the defaults merely to change a small number of config
options such as server: true and bootstrap_expect on server nodes.

Allow sites to specify a baseline set of config items to be applied to
all nodes via config_defaults that can be overridden via hash
merge with config_hash. This doesn't change the current behavior
for users, but allows users running both agents and servers
to consolidate defaults for both roles in a single key instead
of repeating the defaults merely to change a small number of config
options such as server: true and bootstrap_expect on server nodes.
@michaeltchapman
Copy link
Contributor Author

I have an example here if this seems a bit strange:

https://github.com/michaeltchapman/vagrant-consul/blob/master/hiera/data/modules/consul.yaml
https://github.com/michaeltchapman/vagrant-consul/blob/master/hiera/data/roles/server.yaml

So I'm not having to repeat the same common data across roles.

solarkennedy added a commit that referenced this pull request Dec 8, 2014
Add config_defaults hash parameter
@solarkennedy solarkennedy merged commit f245198 into voxpupuli:master Dec 8, 2014
@solarkennedy
Copy link
Contributor

I would normally insist that this kind of code+logic live in what I would call "profile_consul", but being a hash, I understand why this would be useful. I believe this PR does make this module more usable in this regard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants