Notify consul service #95
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is surprising and shouldn't be necessary. |
|
Can you give me some output where you make a config change and puppet does not restart consul? |
|
Closing due to inactivity. @dominikschulz recently this code has changed to try to minimize the restarts and does reloads when possible. Can you try again on master and open a new issue if it still happens? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the notification dependency to notify the Consul Service instead of the Run Service Class.
In my tests this did result in correctly restarted consul instances after configuration changes. Without this patch consul was lacking necessary restarts/reloads.