Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo fix #1

Merged
merged 2 commits into from
Feb 19, 2015
Merged

Typo fix #1

merged 2 commits into from
Feb 19, 2015

Conversation

pehlert
Copy link
Contributor

@pehlert pehlert commented Feb 12, 2015

This fixes a typo which apparently went unnoticed for quite a while. I have been using your library for about a year now and never encountered this problem until a recent update to node 0.12.

Anyway, this should be straight-forward to accept, so I haven't put more effort into the investigation. Would be great to see an updated version (and tailfd) soon.

Thanks!

Pascal Ehlert added 2 commits February 12, 2015 19:01
@pehlert
Copy link
Contributor Author

pehlert commented Feb 12, 2015

Okay apparently there seems to be more to the problem than this. I am now getting a new error:

TypeError: Cannot read property 'fd' of undefined
system-0 (err):     at StatWatcher.<anonymous> (/system/application/node_modules/tailfd/node_modules/watchfd/watch.js:175:45)
system-0 (err):     at StatWatcher.emit (events.js:110:17)
system-0 (err):     at StatWatcher._handle.onchange (fs.js:1230:10)

I might put some effort into this a bit later.

@soldair
Copy link
Owner

soldair commented Feb 19, 2015

interesting ill check it out too. sorry for the issue

@soldair
Copy link
Owner

soldair commented Feb 19, 2015

ok i think i figured it out. crazy that its been missing for so long but it should read prev.ino when looking for the fd instead of cur.ino as well thanks for the help ill merge this and add the next fix and publish to npm

soldair added a commit that referenced this pull request Feb 19, 2015
@soldair soldair merged commit 1b8e249 into soldair:master Feb 19, 2015
@soldair
Copy link
Owner

soldair commented Feb 19, 2015

it must have been working before node v0.12 because it always hit the nlink === 0 insead of missing cur.ino

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants