Fixed define check #4
Conversation
This was breaking on chatspaces, but this fix works!
|
second commit relates to a dom exception that was being created because width/height were set to 0 even though they were already set on https://github.com/sole/Animated_GIF/blob/master/src/Animated_GIF.js#L9 since width/height are already set in the scope, it probably doesn't need to be passed in through addFrame as arguments for setSize. this also got rid of my dom exception error on chatspaces. |
| this.setSize = function(w, h) { | ||
| width = w; | ||
| height = h; | ||
| this.setSize = function() { |
There was a problem hiding this comment.
I don't understand why would you remove the parameters for this function whose purpose is to set the width and height - it either is an issue of the API not being clear or another issue that throws the DOM exception you're getting somewhere else. Maybe you're setting the width and height to 0 inadvertently?
There was a problem hiding this comment.
No idea - I moved the gumhelper calls to a factory in Angular and it kept throwing an undefined with the way it was set before - when I made this change it was happy. You could try changing the version back to yours locally for chatspaces in bower to see it behave
|
I'm not going to merge it because you're changing the API (for bad), but I'm going to port the proper |
This was breaking on chatspaces, but this fix works!