Named parameters rule #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanpcapurro
force-pushed
the
named-parameters-rule
branch
from
be8ba42
to
162fb96
Compare
juanpcapurro
force-pushed
the
named-parameters-rule
branch
4 times, most recently
from
3f69e41
to
91048dc
Compare
|
Not able to review RN but I'm absolutely in favor of such a rule - I'd apply it everywhere |
juanpcapurro
force-pushed
the
named-parameters-rule
branch
from
91048dc
to
503c48f
Compare
I need to change the behaviour of how a value of 0 is interpreted in the config and I need to make sure I don't break the behaviour of other rules in the process.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should close #7
I'd like @DrakeEvans feedback since you reported it, and @PaulRBerg 's since I have seen you be very vocal about using named function parameters 馃檭