Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trap and report login errors #16

Closed
wants to merge 1 commit into from
Closed

trap and report login errors #16

wants to merge 1 commit into from

Conversation

jeff-zucker
Copy link
Member

Traps and reports three kinds of errors when attempting to get a cookie:

  • failed fetch
  • fetched but login failed (400,no cookie)
  • fetched, other bad response

I am assuming that a success returns 302.

@josephguillaume
Copy link

Looks good to me. Improves robustness/usability and only applies to getNodeSolidServerCookie, so it's something that won't be covered by other auth libraries.

@michielbdejong michielbdejong deleted the branch solid-contrib:master September 28, 2022 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants