Fix broken dependency #26
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had form-urlencoded 4.14. Later versions in the 4 series e.g. 4.5.1 broke solid-auth-fetcher.'s nodejs login. Form-urlencoded has gone through some er, changes - bumped to version 5, then 6 in the past month. The latest, 6.0.4 works with solid-auth-fetcher. This should resolve #25
|
@jaxoncreed or @michielbdejong , could you make an npm release after this merge - I am getting multiple complaints from users of solid-node-client. If it would be helpful, feel free to give me rights and I'll do it myself :-). |
|
I assume you're https://www.npmjs.com/~jeff-zucker - invited you! |
|
@michielbdejong excellent, thanks! Now I need rights to this github repo so I can push the PR and then npm it. |
|
This PR replaced by #27 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had form-urlencoded 4.1.4. Later versions in the 4 series e.g. 4.5.1 broke solid-auth-fetcher.'s nodejs login. Form-urlencoded has gone through some er, changes - bumped to version 5, then 6 in the past month. The latest, 6.0.4 works with solid-auth-fetcher. This should resolve #25