Skip to content

Commit

Permalink
Resolve solid/web-access-control-spec#105
Browse files Browse the repository at this point in the history
  • Loading branch information
@michielbdejong
michielbdejong committed Jun 29, 2022
1 parent 06c1f13 commit 5229297
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 17 deletions.
2 changes: 1 addition & 1 deletion package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
},
"scripts": {
"build": "echo nothing to build",
"jest": "jest",
"jest": "jest test/surface/update.test.ts",
"test": "echo nothing to test these tests",
"postversion": "git push --follow-tags"
},
Expand Down
28 changes: 12 additions & 16 deletions test/surface/create.test.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -187,8 +187,7 @@ describe('Create', () => {
testAllowed('Write', 'Write');
testAllowed('Append', 'Write');

// DISPUTED - see https://github.com/solid/web-access-control-spec/issues/105
it.skip(`is disallowed without default Write`, async () => {
it(`is disallowed without default Write`, async () => {
const testing = `test-disallowed-default`;
const containerUrl = makeContainerUrl(testFolderUrl, using, testing);
// This will do mkdir-p:
Expand Down Expand Up @@ -220,7 +219,7 @@ describe('Create', () => {
expect(result.status).toEqual(403);
});

it(`is disallowed without accessTo Write or Append`, async () => {
it(`is disallowed without accessTo Write`, async () => {
const testing = `test-disallowed-accessTo`;
const containerUrl = makeContainerUrl(testFolderUrl, using, testing);
// This will do mkdir-p:
Expand All @@ -235,7 +234,7 @@ describe('Create', () => {
const aclDocUrl = await solidLogicAlice.findAclDocUrl(containerUrl);
await solidLogicAlice.fetch(aclDocUrl, {
method: 'PUT',
body: makeBody('acl:Read, acl:Control', 'acl:Read, acl:Append, acl:Write, acl:Control', containerUrl),
body: makeBody('acl:Read, acl:Append, acl:Control', 'acl:Read, acl:Append, acl:Write, acl:Control', containerUrl),
headers: {
'Content-Type': 'text/turtle',
// 'If-None-Match': '*' - work around a bug in some servers that don't support If-None-Match on ACL doc URLs
Expand Down Expand Up @@ -293,8 +292,7 @@ describe('Create', () => {
testAllowed('Write', 'Write');
testAllowed('Append', 'Write');

// DISPUTED - see https://github.com/solid/web-access-control-spec/issues/105
it.skip(`is disallowed without default Write`, async () => {
it(`is disallowed without default Write`, async () => {
const testing = `test-disallowed-default`;
const containerUrl = makeContainerUrl(testFolderUrl, using, testing);
// This will do mkdir-p:
Expand Down Expand Up @@ -330,7 +328,7 @@ describe('Create', () => {
expect(result.status).toEqual(403);
});

it(`is disallowed without accessTo Write or Append`, async () => {
it(`is disallowed without accessTo Write`, async () => {
const testing = `test-disallowed-accessTo`;
const containerUrl = makeContainerUrl(testFolderUrl, using, testing);
// This will do mkdir-p:
Expand All @@ -345,7 +343,7 @@ describe('Create', () => {
const aclDocUrl = await solidLogicAlice.findAclDocUrl(containerUrl);
await solidLogicAlice.fetch(aclDocUrl, {
method: 'PUT',
body: makeBody('acl:Read, acl:Control', 'acl:Read, acl:Append, acl:Write, acl:Control', containerUrl),
body: makeBody('acl:Read, acl:Append, acl:Control', 'acl:Read, acl:Append, acl:Write, acl:Control', containerUrl),
headers: {
'Content-Type': 'text/turtle',
// 'If-None-Match': '*' - work around a bug in some servers that don't support If-None-Match on ACL doc URLs
Expand Down Expand Up @@ -404,8 +402,7 @@ describe('Create', () => {
testAllowed('Write', 'Write');
testAllowed('Append', 'Write');

// DISPUTED - see https://github.com/solid/web-access-control-spec/issues/105
it.skip(`is disallowed without default Write`, async () => {
it(`is disallowed without default Write`, async () => {
const testing = `disallowed-default`;
const containerUrl = makeContainerUrl(testFolderUrl, using, testing);
// This will do mkdir-p:
Expand Down Expand Up @@ -437,7 +434,7 @@ describe('Create', () => {
expect(result.status).toEqual(403);
});

it(`is disallowed without accessTo Write or Append`, async () => {
it(`is disallowed without accessTo Write`, async () => {
const testing = `disallowed-accessTo`;
const containerUrl = makeContainerUrl(testFolderUrl, using, testing);
// This will do mkdir-p:
Expand All @@ -452,7 +449,7 @@ describe('Create', () => {
const aclDocUrl = await solidLogicAlice.findAclDocUrl(containerUrl);
await solidLogicAlice.fetch(aclDocUrl, {
method: 'PUT',
body: makeBody('acl:Read, acl:Control', 'acl:Read, acl:Append, acl:Write, acl:Control', containerUrl),
body: makeBody('acl:Read, acl:Append, acl:Control', 'acl:Read, acl:Append, acl:Write, acl:Control', containerUrl),
headers: {
'Content-Type': 'text/turtle',
// 'If-None-Match': '*' - work around a bug in some servers that don't support If-None-Match on ACL doc URLs
Expand Down Expand Up @@ -512,8 +509,7 @@ describe('Create', () => {
testAllowed('Write', 'Write');
testAllowed('Append', 'Write');

// DISPUTED - see https://github.com/solid/web-access-control-spec/issues/105
it.skip(`is disallowed without default Write`, async () => {
it(`is disallowed without default Write`, async () => {
const testing = `disallowed-default`;
const containerUrl = makeContainerUrl(testFolderUrl, using, testing);
// This will do mkdir-p:
Expand Down Expand Up @@ -547,7 +543,7 @@ describe('Create', () => {
expect(result.status).toEqual(403);
});

it(`is disallowed without accessTo Write or Append`, async () => {
it(`is disallowed without accessTo Write`, async () => {
const testing = `disallowed-default`;
const containerUrl = makeContainerUrl(testFolderUrl, using, testing);
// This will do mkdir-p:
Expand All @@ -562,7 +558,7 @@ describe('Create', () => {
const aclDocUrl = await solidLogicAlice.findAclDocUrl(containerUrl);
await solidLogicAlice.fetch(aclDocUrl, {
method: 'PUT',
body: makeBody('acl:Read, acl:Control', 'acl:Read, acl:Append, acl:Write, acl:Control', containerUrl),
body: makeBody('acl:Read, acl:Append, acl:Control', 'acl:Read, acl:Append, acl:Write, acl:Control', containerUrl),
headers: {
'Content-Type': 'text/turtle',
// 'If-None-Match': '*' - work around a bug in some servers that don't support If-None-Match on ACL doc URLs
Expand Down

0 comments on commit 5229297

Please sign in to comment.