fix: removing shadow-md token #963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
van-nguyen-ht
added
🚧🛑🚧 waiting for DEV 🚧🛑🚧
mariohamann
changed the title
|
This is a breaking change. Please ensure that when you finally commit. |
|
@mariohamann ma |
|
We don't know, if others used the shadow. As these tokens were public facing, it is a breaking change if it's removed now. |
mariohamann
changed the title
|
@mariohamann it's alright I will add to release note :) |
karlbaumhauer
approved these changes
Apr 30, 2024
3 tasks
van-nguyen-ht
added a commit
that referenced
this pull request
May 3, 2024
) ## Description: link to ticket #963 following [#573](#573) closes #573 shadow-md was created from the style importing from the old sketch file. Since in the new design, it's visually sufficient for the map marker to consume the shadow token, this token is no longer valid and need to be deprecated at releasing ## Definition of Reviewable: *PR notes: Irrelevant elements should be removed.* - [x] Documentation is created/updated - [x] Migration Guide is created/updated - [x] relevant tickets are linked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
following #573
shadow-md was created from the style importing from the old sketch file.
Since in the new design, it's visually sufficient for the map marker to consume the shadow token, this token is no longer valid and need to be deprecated at releasing
Definition of Reviewable:
PR notes: Irrelevant elements should be removed.