-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed popup overflow by suggestions #35
Conversation
Wrapped the popup content in a SingleChildScrollView; Constrained the height of the popup; Changed the `MistakeBuilderCallback` typedef to match the signature of the `LanguageToolMistakePopup` unnamed constructor for simpler interoperability.
Changed `Wrap` to `SliverList.builder` with a `CustomScrollView`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done, @mitryp. I've added a couple of suggestions here - please, take a look.
for them to be before the constructor.
I must have missed something. Will fix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done investigating the problem, @mitryp. I've added one more suggestion here - please, take a look.
In cases when its size was calculated to fill the available space pixel-perfect.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just remove the commented code.
Fixes #32
Fixes #36
Wrapped the popup content in a SingleChildScrollView;
Constrained the height of the popup;
Added the
maxHeight
optional parameter to the LanguageToolMistakePopup;Changed the
MistakeBuilderCallback
typedef to match the signature of theLanguageToolMistakePopup
unnamed constructor for simpler interoperability.