Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update throttling dependency #79

Merged
merged 2 commits into from Jan 30, 2024
Merged

Update throttling dependency #79

merged 2 commits into from Jan 30, 2024

Conversation

ghost
Copy link

@ghost ghost commented Jan 30, 2024

No description provided.

@@ -20,15 +20,15 @@ class DebounceLangToolService extends LanguageCheckService {
@override
Future<Result<List<Mistake>>> findMistakes(String text) async {
final value =
await debouncing.debounce(() => baseService.findMistakes(text))
(await debouncing.debounce(() => baseService.findMistakes(text)) ?? [])
as Result<List<Mistake>>;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Casts should be obsolete now.

Suggested change
as Result<List<Mistake>>;
;

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like they don't

image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right -- because you're trying to assign a List instead of Result<List> -- so the static analyzer gets confused and downgrades everything to Object.

@@ -30,7 +30,7 @@ class ThrottlingLangToolService extends LanguageCheckService {

@override
Future<void> dispose() async {
await throttling.close();
throttling.close();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Throttling has a generic arg too, let's remove the typecast

Copy link
Collaborator

@solid-yuriiprykhodko solid-yuriiprykhodko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@solid-yuriiprykhodko solid-yuriiprykhodko merged commit 4035635 into solid-software:main Jan 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants