Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Generate :next and :edge docker tags #1141

Merged
merged 1 commit into from
Feb 7, 2022
Merged

Conversation

Falx
Copy link
Contributor

@Falx Falx commented Feb 4, 2022

📁 Related issues

#1140

✍️ Description

This PR will add 2 new docker tags to the official docker image by updating the CI.


branch: main
docker tag: :edge

This tag would be generated on each commit push on the main branch. The idea is that you can have a docker image of the latest developments. I suggest :edge in favor of the earlier proposed :dev tagname, because it better self-explains what it is. It is on the edge of the main repository. If you need that for development, you'll pick it.
If we were to use the :dev tag, you first have to at least find out what that really means.


branch: versions/*
docker tag: :next

This tag would be generated on each commit push on the versions/* branch. There should only be one version there that is being prepared. This tag will guarantee an image with the latest upcoming version features.


✅ PR check list

Before this pull request can be merged, a core maintainer will check whether

  • this PR is labeled with the correct semver label
    • semver.patch: Backwards compatible bug fixes.
    • semver.minor: Backwards compatible feature additions.
    • semver.major: Breaking changes. This includes changing interfaces or configuration behaviour.
  • the correct branch is targeted. Patch updates can target main, other changes should target the latest versions/* branch.
  • the RELEASE_NOTES.md document in case of relevant feature or config changes.

@Falx Falx changed the title Generate :next and :edge docker tags feat: Generate :next and :edge docker tags Feb 4, 2022
@Falx Falx marked this pull request as ready for review February 4, 2022 09:56
@Falx Falx requested a review from joachimvh February 4, 2022 13:27
Copy link
Member

@joachimvh joachimvh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@joachimvh joachimvh merged commit 9527b73 into main Feb 7, 2022
@joachimvh joachimvh deleted the feat/docker-tags branch February 7, 2022 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants