Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Folders do not expand when visiting someone else's Pod #6

Closed
megoth opened this issue Nov 8, 2019 · 3 comments
Closed

Folders do not expand when visiting someone else's Pod #6

megoth opened this issue Nov 8, 2019 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@megoth
Copy link
Contributor

megoth commented Nov 8, 2019

This bug has been noted in the forum and on Gitter.

When you're authenticated and visiting a Pod belonging to another WebID, it will not expand folders when you try to expand them clicking on the caret.

@megoth megoth self-assigned this Nov 8, 2019
@megoth megoth added the bug Something isn't working label Nov 8, 2019
@megoth
Copy link
Contributor Author

megoth commented Nov 8, 2019

Findings till now:

  • This only triggers when I'm authenticated with a WebID on the same top-domain (e.g. authenticated with megoth-test.solid.community/profile/card#me will cause an error on megoth.solid.community/public, but megoth.inrupt.net/profile/card#me won't I had a trustedApp-triple that white-listed megoth.solid.community in megoth.inrupt.net/profile/card#me, that's why it didn't fail... It does indeed fail with other top domains as well
  • The problem seems to stem from a faulty error handling when trying to fetch preferences, which leads me to think it's connected to the logic that tries to figure out which views to present to the user
  • I'm unable to reproduce this locally, so I suspect this was fixed in solid-ui@1.2.4

We shouldn't make so many calls to preferences in any case, so I'll create a fix addressing that. But apart from that I'll wait till there's an update to dev.inrupt.net to see if the problem is solved there.

@mikeadams1
Copy link

I have known about this for awhile and consider those who are using the data-browser as a web app in development should do /public/ instead of /public should solve the issues but, I am also looking into why this happens, I expect as you do that, it has something to do with the logic

@megoth
Copy link
Contributor Author

megoth commented Nov 8, 2019

I have not been able to reproduce this on the latest deployment of mashlib, which is available on https://dev.inrupt.net/ - it should be deployed to solid.community and inrupt.net next week unless we find show-stopping bugs.

I will close this issue for now.

@megoth megoth closed this as completed Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants