Added TypeScript to make code base easier to maintain #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vinnl
suggested changes
Jul 23, 2019
|
|
||
| /* Strict Type-Checking Options */ | ||
| "strict": true, /* Enable all strict type-checking options. */ | ||
| "noImplicitAny": true, /* Raise error on expressions and declarations with an implied 'any' type. */ |
There was a problem hiding this comment.
It appears we don't have implicit any's anywhere, so I think it'd be better to turn this flag off.
Edit: oops, the flag is on; it's just that it's not necessary since it's implied by strict: true :)
Suggested change
| "noImplicitAny": true, /* Raise error on expressions and declarations with an implied 'any' type. */ | |
| // "noImplicitAny": true, /* Raise error on expressions and declarations with an implied 'any' type. */ |
Vinnl
approved these changes
Jul 23, 2019
Vinnl
suggested changes
Jul 23, 2019
There was a problem hiding this comment.
There are a lot of added optional keys added in package-lock.json, which is due to your using the npm from Node 12 instead of the one from Node 10 that was used previously. Could you either regenerate it with Node 10, or add an .nvmrc with 12 as its contents, indicating that everybody should be using that?
Also adding .nvmrc so it's easier to be consistent about being on the same version
|
@Vinnl I've added a .nvmrc file and regenerated package-lock.json with Node v8.16.0. |
Vinnl
approved these changes
Jul 23, 2019
Adding prettier and Standard JS to maintain code base better
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.