Define WebSocketSubscription2021 type for Solid Notifications #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acoburn
changed the title
csarven
reviewed
Jan 9, 2022
There was a problem hiding this comment.
I suppose it is feasible to have a WebSocket endpoint that accepts different subscription types. In that case, the protocol parameter should have a value. If the general idea / best practice for servers to allow only one type of subscription per endpoint, this should be mentioned. See the comments on some things to consider towards failing or opening a connection.
Co-authored-by: Sarven Capadisli <info@csarven.ca>
|
It is entirely possible for a WebSocket endpoint to support different subscription types. As for whether it's best to have one endpoint per type or to put all of the types on a single endpoint -- that's really an implementation decision |
elf-pavlik
approved these changes
Jan 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This defines the
WebSocketSubscription2021type in an independent specification document.