Create solid-manager.md #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mitzi-Laszlo
added
the
manager application
|
To align with current convention (i.e. editors.md, panels.md, administrators.md), suggest renaming this to managers.md. |
justinwb
requested changes
Aug 21, 2019
There was a problem hiding this comment.
Generally fine - tiny grammar changes needed.
Should also consider changing the name to "managers.md", which aligns with the pattern being used for other roles. I think this supports the opportunity for multiple managers at some point (if necessary), as well as to keep a history of past / alumni managers (same goes for other roles). Since this isn't the situation today this wouldn't block my 👍, but might be better to make the change now than to make it later.
justinwb
approved these changes
Aug 29, 2019
timbl
approved these changes
Aug 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.