Updates same row when entering new domain for trusted app #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for #170 Also contains some clean-up of syntax (scout rule)
megoth
added
the
release-patch
Vinnl
approved these changes
Sep 24, 2019
There was a problem hiding this comment.
I'm not quite sure what createContainer, createElement and createText do, but I'm assuming it's pretty much what I'd expect. Still not entirely clear to me what exactly this change does, but I'm trusting it'll be the right thing.
One request for next time though: if you do a general code cleanup, could you do that in a separate commit? Then I can review the relevant change by itself, and just scan over the cleanup diffs. Thanks!
Co-Authored-By: Vincent <Vinnl@users.noreply.github.com>
Ah, yes, that was lazy of me. Will do next time ^_^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #170
Also contains some clean-up of syntax (scout rule)