Skip to content

Commit

Permalink
Merge pull request #140 from solidjs-community/feature/eslint-v9
Browse files Browse the repository at this point in the history
ESLint v9 backwards-compatible support
  • Loading branch information
joshwilsonvu committed Apr 27, 2024
2 parents 4bc8e38 + 6dda5b1 commit 1943297
Show file tree
Hide file tree
Showing 40 changed files with 1,768 additions and 1,866 deletions.
2 changes: 0 additions & 2 deletions .eslintignore
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,3 @@ dist
dist.*
./configs
node_modules
jest.config.js
jest.setup.js
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node: ["16", "18", "20"]
node: ["18", "20", "22"]
steps:
- uses: actions/checkout@v4
- name: Setup pnpm
Expand Down
8 changes: 0 additions & 8 deletions docs/jsx-no-undef.md
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,6 @@ let el = <div use:X />;

let el = <div use:X={{}} />;

let el = <div use:X />;

/* eslint solid/jsx-no-undef: ["error", { "allowGlobals": true }] */
let el = <div use:X />;

Expand Down Expand Up @@ -161,12 +159,6 @@ let X,
let Component,
X = <Component use:X />;

/* eslint solid/jsx-no-undef: ["error", { "allowGlobals": true }] */
let el = <div use:X />;

/* eslint solid/jsx-no-undef: ["error", { "allowGlobals": true }] */
let el = <div use:X />;

/* eslint solid/jsx-no-undef: ["error", { "typescriptEnabled": true }] */
let el = <Component />;

Expand Down
5 changes: 0 additions & 5 deletions docs/reactivity.md
Original file line number Diff line number Diff line change
Expand Up @@ -318,11 +318,6 @@ const Component = () => {
return <button type={signal}>Button</button>;
};

const Component = () => {
const [signal] = createSignal();
return <div>{signal}</div>;
};

const Component = () => {
const [signal] = createSignal("world");
const memo = createMemo(() => "hello " + signal);
Expand Down
7 changes: 0 additions & 7 deletions jest.config.js

This file was deleted.

28 changes: 15 additions & 13 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,9 @@
"prepare": "husky install",
"prepublishOnly": "pnpm build && pnpm lint && prettier --check src && pnpm test:all",
"build": "tsc -p tsconfig.build.json && pnpm run docs",
"lint": "eslint --ignore-pattern test/fixture/invalid .",
"docs": "PARSER=none ts-node --transpile-only scripts/docs.ts",
"test": "jest",
"lint": "eslint --ext .js,.jsx,.ts,.tsx --ignore-pattern test/fixture/invalid .",
"docs": "PARSER=none tsx scripts/docs.ts",
"test": "vitest",
"test:ts": "PARSER=ts pnpm test",
"test:babel": "PARSER=babel pnpm test",
"test:v6": "PARSER=v6 pnpm test",
Expand All @@ -37,7 +37,7 @@
"README.md"
],
"dependencies": {
"@typescript-eslint/utils": "^6.21.0",
"@typescript-eslint/utils": "^7.6.0",
"estraverse": "^5.3.0",
"is-html": "^2.0.0",
"kebab-case": "^1.0.2",
Expand All @@ -48,29 +48,31 @@
"@babel/core": "^7.24.4",
"@babel/eslint-parser": "^7.24.1",
"@tsconfig/node20": "^20.1.4",
"@types/eslint": "^8.56.7",
"@types/eslint-v6": "npm:@types/eslint@6",
"@types/eslint-v7": "npm:@types/eslint@7",
"@types/eslint-v8": "npm:@types/eslint@8",
"@types/estraverse": "^5.1.7",
"@types/is-html": "^2.0.2",
"@types/jest": "^29.5.12",
"@types/markdown-magic": "^1.0.4",
"@types/node": "^16.18.94",
"@types/prettier": "^2.7.3",
"@typescript-eslint/eslint-plugin": "^6.21.0",
"@typescript-eslint/parser": "^6.21.0",
"eslint": "^8.57.0",
"eslint": "^9.0.0",
"eslint-plugin-eslint-plugin": "^5.5.0",
"eslint-plugin-import": "^2.29.1",
"eslint-plugin-solid": "link:",
"eslint-v6": "npm:eslint@^6.8.0",
"eslint-v7": "npm:eslint@^7.32.0",
"eslint-v6": "npm:eslint@6",
"eslint-v7": "npm:eslint@7",
"eslint-v8": "npm:eslint@8",
"husky": "^8.0.3",
"jest": "^29.7.0",
"lint-staged": "^13.3.0",
"markdown-magic": "^2.6.1",
"prettier": "^2.8.8",
"ts-jest": "^29.1.2",
"ts-node": "^10.9.2",
"typescript": "^5.4.3"
"tsx": "^4.7.3",
"typescript": "^5.4.3",
"typescript-eslint": "^7.7.1",
"vitest": "^1.5.2"
},
"peerDependencies": {
"eslint": "^6.0.0 || ^7.0.0 || ^8.0.0"
Expand Down
Loading

0 comments on commit 1943297

Please sign in to comment.