Skip to content

Commit

Permalink
Lint and typescript fixes.
Browse files Browse the repository at this point in the history
  • Loading branch information
joshwilsonvu committed Apr 27, 2024
1 parent 417571d commit e0c311f
Show file tree
Hide file tree
Showing 6 changed files with 12 additions and 10 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
- name: Run build
run: pnpm run build
- name: Lint source code
run: pnpm run lint --max-warnings=0
run: pnpm run lint -- --max-warnings=0
- name: Run all tests
run: pnpm run test:all
- name: Sanity check standalone build
Expand Down
2 changes: 1 addition & 1 deletion scripts/docs.ts
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ const buildRulesTable = (rows: Array<string>) => {
const buildHeader = (filename: string): string => {
const ruleName = filename.replace(/\.md$/, "");
if (!rules[ruleName]) return " ";
const meta: TSESLint.RuleMetaData<never> = rules[ruleName].meta;
const meta: TSESLint.RuleMetaData<string, readonly unknown[]> = rules[ruleName].meta;
return [
`# solid/${ruleName}`,
meta.docs?.description,
Expand Down
2 changes: 2 additions & 0 deletions test/fixture.test.ts
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import { test, expect } from "vitest";

import path from "path";
// @ts-expect-error Type definitions not updated to include FlatESLint
import { ESLint as FlatESLint } from "eslint";
Expand Down
2 changes: 2 additions & 0 deletions test/format.test.ts
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import { test, expect } from "vitest";

import recommendedConfig from "eslint-plugin-solid/configs/recommended";
import typescriptConfig from "eslint-plugin-solid/configs/typescript";
import plugin from "eslint-plugin-solid";
Expand Down
6 changes: 6 additions & 0 deletions vitest.config.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
export default {
test: {
globals: true,
setupFiles: ["vitest.setup.js"],
},
};
8 changes: 0 additions & 8 deletions vitest.config.ts

This file was deleted.

0 comments on commit e0c311f

Please sign in to comment.