New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Types don't exist in bundled package #128
Comments
It seems like you are looking to use flat config, but the eslint-plugin-solid does not export flat config from the root of the module. Please refer to this link: https://github.com/solidjs-community/eslint-plugin-solid#flat-configuration However, not exporting the type is actually a bug, so I will submit a PR for that. Additionally, since other plugins supporting flat config export it from the root of the module, I will also submit a separate PR to export flat config from the root of the module for consistency. |
Thank you both—as you can probably expect, shipping types hasn't really been a priority until now, but it makes sense for use with flat config. I'll take a look at that PR |
I am also experiencing this issue, could this be merged? Thank you |
I have opened a PR: #135. Reviews are welcome. |
Describe the bug
I'm trying to use
eslint-plugin-solid
in aneslint.config.js
with TypeScript'scheckJs: true
.eslint-plugin-solid
'spackage.json
claimsdist/index.d.ts
should exist:eslint-plugin-solid/package.json
Line 13 in 02d7879
...but that file doesn't exist in the published package.
https://arethetypeswrong.github.io/?p=eslint-plugin-solid%400.13.1:
Import resolved to JavaScript files, but no type declarations were found.
To Reproduce
https://www.typescriptlang.org/play?#code/JYWwDg9gTgLgBAZwgG2AEzgMyhEcBEApgqgHYwC0YyArgObCkVKpr4DcAUJ4QB6Sw4aQpgCGNZPADaLdAF12QA
Expected behavior
Types should be included with the package.
Environment (please complete the following information):
node --version
): n/aeslint-plugin-solid
version (npm list eslint-plugin-solid
/yarn why eslint-plugin-solid
): 0.13.1eslint
version (npm list eslint
/yarn why eslint
): n/aAdditional context
The text was updated successfully, but these errors were encountered: