Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage: type fixes #622

Merged
merged 1 commit into from
Apr 26, 2024
Merged

storage: type fixes #622

merged 1 commit into from
Apr 26, 2024

Conversation

atk
Copy link
Member

@atk atk commented Apr 26, 2024

The following code led to type errors:

const [x, setX] = makePersisted(createSignal(""), { storage: cookieStorage, name: "test" })

These type errors are now fixed and the types are even inexplicably simplified. Cheers!

Copy link

changeset-bot bot commented Apr 26, 2024

🦋 Changeset detected

Latest commit: 72db58b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@solid-primitives/storage Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@thetarnav
Copy link
Member

ya broke the build tho!

@thetarnav thetarnav merged commit 214748a into main Apr 26, 2024
3 checks passed
@thetarnav thetarnav deleted the storage-fix-types branch April 26, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants