Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't submit form when submitevent get defaultPrevented #401

Merged
merged 2 commits into from
Apr 10, 2024

Conversation

SarguelUnda
Copy link
Contributor

@SarguelUnda SarguelUnda commented Apr 10, 2024

Fix #400

Objective

The pull request aim to not run action when someone call preventDefault on the submitevent.

Remarks

  1. I didn't run prettier and there is a ts error when I build the project that was already there.
  2. I'm not sure where to abort the handleFormSubmit function I choose to abort as soon as possible but maybe there are better place performance wise

Copy link

changeset-bot bot commented Apr 10, 2024

🦋 Changeset detected

Latest commit: 8a547a8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@solidjs/router Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ryansolid
Copy link
Member

Thanks

@ryansolid ryansolid merged commit 2a6608a into solidjs:main Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

action always trigger on form submit
2 participants