Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug?]: page content gets duplicated when changing source code #1333

Closed
2 tasks done
sina-salahshour opened this issue Feb 14, 2024 · 5 comments
Closed
2 tasks done
Assignees
Labels
bug Something isn't working

Comments

@sina-salahshour
Copy link

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

Current behavior 馃槸

I created a solid project with pnpm create solid, selected the bare version with no ssr.
launched the dev mode, when i change app.tsx, rendered content gets duplicated without even updating changes.

Expected behavior 馃

update the rendered content to match the source code.

Steps to reproduce 馃暪

Steps:

  1. pnpm create solid
  2. select bare
  3. no ssr
  4. launch dev mode and open a browser
  5. change inside h1 tag on app.tsx

Context 馃敠

No response

Your environment 馃寧

System:
  OS: Linux 6.6.5.16.realtime1-3-rt Arch
  CPU: (12) x86_64
Binaries:
  Node: 20.5.1
  pnpm: 8.12.2
npmPackages:
  @solidjs/start: ^0.5.6
  solid-js: ^1.8.14
  vinxi: ^0.2.1
@sina-salahshour sina-salahshour added the bug Something isn't working label Feb 14, 2024
@lxsmnsyc
Copy link
Member

This happened with the updated on vite-plugin-solid.

For now, the fix is to add // @refresh reload on your entry-client file, but in the future this will be automatically handled.

@ryansolid
Copy link
Member

I've locked the Vite plugin to minor version starting in 0.5.7. You can update to that for now until it is properly tested with SolidStart.

@sina-salahshour
Copy link
Author

Ok, thanks for your time 馃檹馃徎

@ryansolid
Copy link
Member

Sorry about the confusion.. I also reverted the Vite plugin. The change impacted too many projects.

@ryansolid
Copy link
Member

We are still testing the new refresh issue. Since it was reverted and this was "fixed" we will address it when the new one is released if it shows up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants