Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vite 4 / Rollup 3 support #660

Closed
birkskyum opened this issue Jan 19, 2023 · 3 comments · Fixed by #767
Closed

Vite 4 / Rollup 3 support #660

birkskyum opened this issue Jan 19, 2023 · 3 comments · Fixed by #767

Comments

@birkskyum
Copy link
Contributor

The work towards this touches multiple PR's, so this is a tracking issue.
This was referenced Jan 19, 2023
Merged
Merged
Merged
@dtinth dtinth mentioned this issue Jan 20, 2023
Merged
1 task
This was referenced Jan 20, 2023
Merged
Closed
@birkskyum birkskyum mentioned this issue Jan 29, 2023
Merged
@huijiewei
Copy link

Is there any plan to upgrade to vite4, because of the problem of the last / in the subdirectory, vite4 is very important

@birkskyum
Copy link
Contributor Author

I believe the last issue remaining before there is Vite 4 compatibility is the open issue wrt the spa-test referenced here

@huijiewei
Copy link

Because the resolveConfig behavior of vite has changed, the defaultModeEnv parameter has been added, which needs to be set as soon as possible。 so solid-start not set this parameter. vite use default development env.

@huijiewei huijiewei mentioned this issue Feb 17, 2023
Closed
@birkskyum birkskyum mentioned this issue Feb 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Vite 4.1.4 birkskyum/solid-start
2 participants
@huijiewei @birkskyum