Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: support custom options for babel-preset-solid #13

Closed
zhaoyao91 opened this issue Jun 3, 2021 · 1 comment
Closed

feature: support custom options for babel-preset-solid #13

zhaoyao91 opened this issue Jun 3, 2021 · 1 comment

Comments

@zhaoyao91
Copy link

we need to pass in some other options for babel-preset-solid, by searching the code I didn't find a way to give these options.

(I want to pass in "delegateEvents": false)

@amoutonbrady
Copy link
Member

amoutonbrady commented Jun 6, 2021

Hey, that's a good idea. I guess I wanted to make the plugin as lean as possible, but I've come to realize that it might not be the best approach as Solid in general is for people that likes to tinker with configuration and fine tune it to their needs.

This should be fixed. I added a solid option that takes the same options as babel-plugin-jsx-dom-expressions.

There might be some overriding to take care of later on but that should fix your issue for now on :)

Let me know if it works as intended.

edit: this is available in 1.9.0 if you use solid < 1.0.0 or 2.0.0-rc.2 if you use solid 1.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants