Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does this plugin support sourcemaps? #21

Closed
kirkedev opened this issue Oct 30, 2021 · 4 comments
Closed

Does this plugin support sourcemaps? #21

kirkedev opened this issue Oct 30, 2021 · 4 comments

Comments

@kirkedev
Copy link

Hello,

I'm getting sourcemaps for all of my code except the tsx files. Wondering if I'm doing something wrong, or if this just isn't supported (yet?).

@amoutonbrady
Copy link
Member

Theoratically, we should expose sourcemaps for tsx / jsx files as per https://github.com/solidjs/vite-plugin-solid/blob/master/src/index.ts#L332

Let me see if I can reproduce on my side.

@amoutonbrady
Copy link
Member

amoutonbrady commented Nov 4, 2021

I would say it partially work. Not sure if that's the intended behavior or not but I definitely get the origin from the origin file.
However, the mapping is done to the compiled file.
There's probably something better that we can do about it

@amoutonbrady
Copy link
Member

amoutonbrady commented Nov 4, 2021

I've managed to find the issue, there was some missing parameters in the babel config.
Do give it a try an let me know if things work better now :)

Published in vite-plugin-solid@2.1.2

@kirkedev
Copy link
Author

kirkedev commented Nov 4, 2021

Works great! Thanks so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants