Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add solidus static content content provider #12

Merged
merged 1 commit into from
Apr 3, 2020

Conversation

vassalloandrea
Copy link
Contributor

Summary

Add solidus static content - content provider

To retrieve the page we have to pass the page slug to the entry options.
If the page slug is the same as the entry one, we can avoid passing the options.

posts = SolidusContent::EntryType.create(
  name: 'posts',
  content_provider_name: 'solidus_static_content'
)

entry = SolidusContent::Entry.create!(
  slug: '2020-03-27-hello-world',
  entry_type: posts,
  options: { slug: 'XXX' } # Can be omitted if the page slug is the same of the entry
)

@vassalloandrea vassalloandrea self-assigned this Apr 3, 2020
@vassalloandrea vassalloandrea force-pushed the vassalloandrea/add-solidus-static-content-provider branch 2 times, most recently from 38174d7 to 9d5968b Compare April 3, 2020 13:54
Copy link
Member

@elia elia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a suggestion on how to fix the CI

@vassalloandrea vassalloandrea force-pushed the vassalloandrea/add-solidus-static-content-provider branch from 9d5968b to ff6ebd8 Compare April 3, 2020 14:16
@vassalloandrea vassalloandrea force-pushed the vassalloandrea/add-solidus-static-content-provider branch from ff6ebd8 to a8eb104 Compare April 3, 2020 14:20
@vassalloandrea vassalloandrea requested a review from elia April 3, 2020 14:27
@elia elia merged commit 12319b2 into master Apr 3, 2020
@elia elia deleted the vassalloandrea/add-solidus-static-content-provider branch April 3, 2020 15:38
@elia elia mentioned this pull request Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants