Bump spree print invoice to Solidus. #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So as to be able to generate a dummy app properly.
These tests and files don't _really_ test anything. Or offer us any value
Specs for this gem must not have been ran in ages. I haven't seen a spec helper like this. We're going to replace it with one that we're used too for extensions.
These are required for the spree dummy app generator. It absolutely requires these files to exist. Solidus' generator keeps them optional in the dummy app.
For some reason, this just passed in a Sprockets::Asset which prawn can't resolve. It expects a filename.
These are our standard dependencies for when we write specs, most of them assist us with feature testing.
Our application depends on deface. Without this require it does not behave properly in the test environment.
Verify we can change the print invoice settings.
We shouldn't really test the content of the PDF here. We'd essentially be testing Prawn, and while view specs are something we can do we don't normally go through the effort. Here we're just verifying that the PDF can be generated without error and with the correct status code and headers.
Merged
| click_link "Configuration" | ||
|
|
||
| select "Times Roman", from: "print_invoice_font_face" | ||
| fill_in "print_invoice_next_number", with: "150" |
There was a problem hiding this comment.
Maybe use the words of the label instead of the name of the field to target the input?
fill_in("Next Invoice Number", with: "150")
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.