Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Autoloading on Rails 7 #110

Merged
merged 1 commit into from
Nov 2, 2022
Merged

Fix Autoloading on Rails 7 #110

merged 1 commit into from
Nov 2, 2022

Conversation

megatunger
Copy link
Contributor

Due to recently changes on Rails 7, we may facing error like this

in `<module:Reviews>': uninitialized constant Spree::ReviewsConfiguration (NameError)

    Config = Spree::ReviewsConfiguration.new

I think we should wrap in safe loading method to fix this

kennyadsl
kennyadsl previously approved these changes Jul 8, 2022
View reviewed changes
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kennyadsl kennyadsl dismissed their stale review July 8, 2022 14:00

Didn't see specs wasn't passing

@kennyadsl
Copy link
Member

Thanks for contributing. Are the other spec failures related?

@megatunger
Copy link
Contributor Author

No, it does not 👍

@pelargir
Copy link
Contributor

pelargir commented Nov 1, 2022

+1 we are having this problem as well.

@pelargir pelargir mentioned this pull request Nov 2, 2022
Closed
@kennyadsl kennyadsl merged commit 20d0b1a into solidusio-contrib:master Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennyadsl kennyadsl kennyadsl left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@megatunger @kennyadsl @pelargir