Match the Rails name for sqlite in $DB
#66
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sandbox and solidus_core script should already be compatible with the rails-compatible name.
7 tasks
7 tasks
|
Would integrating this fix extension builds like this one? https://app.circleci.com/pipelines/github/solidusio-contrib/solidus_reviews/354/workflows/dfed4692-8b43-4bcc-adf7-4ef0d24bce42/jobs/851 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We traditionally used
sqliteand had code to convert it tosqlite3when using it as arails new --database=…option.Moving to use the same naming simplifies the setup. Sandbox and solidus_core script should already be compatible with the rails-compatible name.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed (
cross them outif they are not):