Remove support for old Ruby versions #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MassimilianoLattanzio
requested review from
DanielePalombo,
abhishekgupta5 and
piyushswain
MassimilianoLattanzio
force-pushed
the
ml/remove-old-ruby-support
branch
2 times, most recently
from
d23ce7e
to
8f9a21e
Compare
DanielePalombo
approved these changes
Jul 24, 2023
abhishekgupta5
approved these changes
Jul 24, 2023
piyushswain
approved these changes
Jul 26, 2023
Some features started failing after adding the support to Ruby 2.4 because we downgraded the rubocop version to 1.12.1 in d525445. Since Ruby 2.4 is no longer supported by rubocop, we decided to require at least ruby 2.7.
After removing ruby 2.4 support, rubocop raises a new offense regarding Rubygems MFA. We disable the cops temporarily to let us deploy the gem.
MassimilianoLattanzio
force-pushed
the
ml/remove-old-ruby-support
branch
from
8f9a21e
to
361daaa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some features started failing after adding the support to Ruby 2.4 because we downgraded the rubocop version to 1.12.1 in d525445.
Since Ruby 2.4 is no longer supported by rubocop, we decided to require at least ruby 2.7.
Closes #46.