Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove taxons jstree route from api #194

Closed
jhawthorn opened this issue Jul 22, 2015 · 3 comments
Closed

Remove taxons jstree route from api #194

jhawthorn opened this issue Jul 22, 2015 · 3 comments
Labels
changelog:solidus_api Changes to the solidus_api gem
Milestone
Future

Comments

@jhawthorn
Copy link
Contributor

Taxons interface in the admin uses jstree to display and edit the taxons. It does this using a "jstree" route in the API which returns taxons in the jstree-specific format. We should instead be using the normal show route and transform it in JS.

I started refactoring the taxons page in #157 but didn't get around to this.
@jhawthorn jhawthorn added the changelog:solidus_api Changes to the solidus_api gem label Jul 22, 2015
@jhawthorn jhawthorn added this to the Future milestone Jul 22, 2015
@jhawthorn
Copy link
Contributor Author

Also at the same time it might be worth removing jstree, which is complex and doesn't provide a particularly good interface (right click to add/edit/rename/remove) compared to a simpler nested sortable.

@graygilmore graygilmore mentioned this issue Jan 7, 2016
Closed
@jarednorman
Copy link
Member

Looks like this is done.

kennyadsl referenced this issue in nebulab/solidus Oct 4, 2017
@kennyadsl
Deprecate JSTree api routes
57484ee 
We are not using JSTree anymore (solidusio#569) but we still have these
routes available for stores that used it outside JSTree scopes.

We decided to deprecate these routes long time ago but we never did it.
See also #194.

Once we've deprecated this enough we can probably just resurrect solidusio#664.
@kennyadsl kennyadsl mentioned this issue Oct 4, 2017
Merged
@jhawthorn
Copy link
Contributor Author

Closing for #2254

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
changelog:solidus_api Changes to the solidus_api gem
Projects
None yet
Milestone
Future
Development

No branches or pull requests
2 participants
@jhawthorn @jarednorman