Fix taxons page with new Spree.ajax calls (and cleanup) #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looking good so far. |
jhawthorn
changed the title
|
👍 |
|
Just rebased and added the small feature spec |
This was missing a necessary {"X-Spree-Token": Spree.api_key }, which
was causing the API call to error. Also cleaned up the rest of the ajax
calls in the file.
This was no longer being used.
jhawthorn
force-pushed
the
taxons_fix
branch
2 times, most recently
from
b714e2f
to
513b55c
Compare
|
👍 |
This wasn't working for me in either chrome or firefox, and is unnecessary as rename is available in the right click menu.
There's no reason for this, renaming works fine without it.
There's already a standard spinner, with the same id as this one. I don't think it was being displayed.
The update button on this page is only used for updating the name of the taxonomy, having it under the tree suggests that it would be used for updating the tree's structure as well.
|
👍 |
1 similar comment
|
👍 |
jhawthorn
added a commit
that referenced
this pull request
Jul 27, 2015
Fix taxons page with new Spree.ajax calls (and cleanup)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was missing a necessary {"X-Spree-Token": Spree.api_key }, which was causing the API call to error. Also cleaned up the rest of the ajax calls in the file.