Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more inline editable tables #2042

Closed
2 tasks
tvdeyen opened this issue Jun 26, 2017 · 1 comment
Closed
2 tasks

Add more inline editable tables #2042

tvdeyen opened this issue Jun 26, 2017 · 1 comment
Labels
changelog:solidus_backend Changes to the solidus_backend gem type:enhancement Proposed or newly added feature

Comments

@tvdeyen
Copy link
Member

tvdeyen commented Jun 26, 2017

As a follow up to the inline-editable-table introduced in #1580 we should have a look into all tables in the admin and see where this new UI component could fit. Also we need to update the style guide

  • Update style guide and show the new UI component
  • Compile a list with tables in the admin that could make use of this component
@tvdeyen tvdeyen added changelog:solidus_backend Changes to the solidus_backend gem beginner-friendly type:enhancement Proposed or newly added feature good first issue Wanted, but lacking time to work on it and might be a good fit for a first contribution labels Jun 26, 2017
@Mandily
Copy link
Contributor

Mandily commented Jun 28, 2017

@mtomov worked on a PR that added inline editing capabilities to the image variants screen to make it quicker and easier for admins to update fields. I think this could be extended to other tables in the admin so that users could both edit and create simple table rows inline instead of needing to go to other pages. I've broken up the opportunities into:

  1. Simply making existing inline editing capabilities available upon hovering of rows. Sometimes we'd be able to remove the edit button from the side if we were also removing a separate edit page, but in the case of pages with a large number of inputs, we'd keep the edit buttons to be able to link the user to that page.
  2. Making interactions consistent and moving save or update functions tied to a table row into icons located at the right side of the table, and removing them from underneath the table.
  3. Moving edit functionality into a table from a separate page (and thus removing the need for the separate page and for an edit button at the right side of the table)
  4. Moving new functionality into a table from a separate page (and thus removing the need for a separate page and for a new button in the header or elsewhere on the page.)

I’ve made a list of tables and what would need to be done to move edit and new functionality into the table here

Let me know if there's any questions/concerns about this.

@Mandily Mandily mentioned this issue Jul 19, 2017
@graygilmore graygilmore mentioned this issue Jul 24, 2017
4 tasks
@kennyadsl kennyadsl removed the good first issue Wanted, but lacking time to work on it and might be a good fit for a first contribution label Apr 6, 2021
@solidusio solidusio locked and limited conversation to collaborators Sep 8, 2022
@waiting-for-dev waiting-for-dev converted this issue into discussion #4620 Sep 8, 2022

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
changelog:solidus_backend Changes to the solidus_backend gem type:enhancement Proposed or newly added feature
Projects
None yet
Development

No branches or pull requests

3 participants