Deprecation warning of paranoia delete

[denis-mueller]

solidus/core/lib/spree/paranoia_deprecations.rb

Lines 13 to 19 in 859143f

	def paranoia_delete
	Spree::Deprecation.warn <<-WARN.strip_heredoc, caller
	Calling #delete (or #paranoia_delete) on a #{self.class} currently performs a soft-destroy using the paranoia gem.
	In Solidus 3.0, paranoia will be removed, and this will perform a HARD destroy instead. To continue soft-deleting, use #discard instead.
	WARN
	super
	end

Gemfile: https://gist.github.com/denis-mueller/d62712801b730f5d6829ea4070376335
Gemfile.lock: https://gist.github.com/denis-mueller/b5bf01f2261601ebb2c2739674a27b15

By setting the prices for a Product's Variant, the old prices get deleted (because the Variant has many Prices with dependent: destroy)

      product.master.prices = [
        create(:price, amount: 4, currency: 'CHF'),
        create(:price, amount: 5, currency: 'EUR')
      ]

This prints out the following deprecation warning:

DEPRECATION WARNING: Calling #delete (or #paranoia_delete) on a Spree::Price currently performs a soft-destroy using the paranoia gem.
In Solidus 3.0, paranoia will be removed, and this will perform a HARD destroy instead. To continue soft-deleting, use #discard instead.

What can I do so that I don't get the deprecation warning anymore?

[kennyadsl]

@denis-mueller I think it's an issue with the discard gem, and I've opened an issue there. Let's see what's the best way to move forward on this and thanks for pointing out the issue.

[kennyadsl]

For now, if you want to remove the warning, you can do something like:

product.master.prices.discard_all
product.master.prices = [
  create(:price, amount: 4, currency: 'CHF'),
  create(:price, amount: 5, currency: 'EUR')
]

Let me know if this works!

[jarednorman]

With no activity in over a year, I think we can close this.