Fix sidebar vertical alignment #1845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The sidebar is currently not correctly vertically aligned to the fieldset it most of the time is displayed with (ie. in the order detail views and the user detail views). Use a relatively unit for top margin instead and move the top border to the heading to respect the column gutter.
We use dd and dt elements in the sidebar. Using justified text reduces readability of titles and values with multiple words.
tvdeyen
added
changelog:solidus_backend
cbrunsdon
approved these changes
Apr 13, 2017
jhawthorn
approved these changes
Apr 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sidebar is currently not correctly vertically aligned to the fieldset
it most of the time is displayed with (ie. in the order detail views and
the user detail views).
Use a relatively unit for top margin instead and move the top border to the
heading to respect the column gutter.
Before
After