Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant methods on Spree::PaymentMethod::StoreCredit #2038

Merged
merged 1 commit into from Jun 28, 2017
Merged

Remove redundant methods on Spree::PaymentMethod::StoreCredit #2038

merged 1 commit into from Jun 28, 2017

Commits on Jun 22, 2017

  1. Remove redundant methods. 

    When a payment source is required, then `can_capture?` and `can_void?`
etc; methods are not needed on the payment method class.

See:
https://github.com/solidusio/solidus/blob/master/core/app/models/spree/payment.rb#L157-L160

When a payment source is present then these methods are delegated to the
payment source class.
    Taylor Scott committed Jun 22, 2017
    Configuration menu
    Copy the full SHA
    f0c8492 View commit details
    Browse the repository at this point in the history