Rename Shipment#update! to Shipment#update_state #2085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jul 12, 2017
core/app/models/spree/shipment.rb
Outdated
| def update!(order_or_attrs) | ||
| if order_or_attrs.is_a?(Spree::Order) | ||
| Spree::Deprecation.warn "Calling Shipment#update! with an order to update the shipments state is deprecated. Please use Shipment#update_state instead." | ||
| if order_or_attrs.object_id != self.order.object_id |
houndci-bot
reviewed
Jul 12, 2017
core/app/models/spree/shipment.rb
Outdated
| def update!(order_or_attrs) | ||
| if order_or_attrs.is_a?(Spree::Order) | ||
| Spree::Deprecation.warn "Calling Shipment#update! with an order to update the shipments state is deprecated. Please use Shipment#update_state instead." | ||
| if order_or_attrs.object_id != self.order.object_id |
houndci-bot
reviewed
Jul 12, 2017
core/app/models/spree/shipment.rb
Outdated
| def update!(order_or_attrs) | ||
| if order_or_attrs.is_a?(Spree::Order) | ||
| Spree::Deprecation.warn "Calling Shipment#update! with an order to update the shipments state is deprecated. Please use Shipment#update_state instead." | ||
| if order_or_attrs.object_id != self.order.object_id |
jhawthorn
changed the title
Overriding shipment.update! prevented us from calling AR::Base#update! on a shipment. This renames Shipment#update! to Shipment#update_state and deprecates calling Shipment#update! with an order as an argument.
jhawthorn
force-pushed
the
shipment_update
branch
from
6066017
to
66aba46
Compare
cbrunsdon
approved these changes
Jul 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overriding shipment.update! prevented us from calling AR::Base#update! on a shipment. This renames Shipment#update! to Shipment#update_state and deprecates calling Shipment#update! with an order as an argument.
Follow up to #2072