Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify "inline" new image form #2391

Merged
merged 2 commits into from
Nov 23, 2017
Merged

Simplify "inline" new image form #2391

merged 2 commits into from
Nov 23, 2017

Conversation

jhawthorn
Copy link
Contributor

There's no need to do ajax here, we can render the form when we load the page.

@jhawthorn
Rewrite images/index.coffee as plain JS
b8a6335
@jhawthorn
Simplify new image "inline" form
8fa3f8c 
There's no need to do ajax here, we can render the form when we load the
page.
cbrunsdon
cbrunsdon approved these changes Nov 22, 2017
View reviewed changes
Copy link
Contributor

@cbrunsdon cbrunsdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haven't pulled it down, but it all looks reasonable to me

tvdeyen
tvdeyen approved these changes Nov 22, 2017
View reviewed changes
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jhawthorn jhawthorn merged commit b584209 into solidusio:master Nov 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tvdeyen tvdeyen tvdeyen approved these changes

@cbrunsdon cbrunsdon cbrunsdon approved these changes

@mamhoff mamhoff mamhoff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jhawthorn @tvdeyen @cbrunsdon @mamhoff