Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Splitting shipment should update order totals/payment status #2555

Merged
merged 1 commit into from
Feb 26, 2018
Merged

Splitting shipment should update order totals/payment status #2555

merged 1 commit into from
Feb 26, 2018

Conversation

vzqzac
Copy link
Contributor

@vzqzac vzqzac commented Feb 2, 2018

Fixes #2554, detailed issue info is in there

Here's a gif with the solution in place:

working

I also added a small test to make sure after calling run! in Spree::FulfilmentChanger the order is properly recalculated

Recalculate order after shipment has proper rates

Reload order before update
@jhawthorn jhawthorn added this to the 2.5.0 milestone Feb 14, 2018
Copy link
Contributor

@jhawthorn jhawthorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Looks good to me.

I'd rather not have the reload, but it does seem necessary.

@vzqzac
Copy link
Contributor Author

vzqzac commented Feb 14, 2018

Thanks for your response @jhawthorn, I'd also prefer not to use it but yeah, it's necessary, in case current_shipment is deleted it is frozen at the time order.updater.update is called and causes runtime errors while trying to update item adjustments in OrderUpdater model

@jhawthorn jhawthorn merged commit 20a2c01 into solidusio:master Feb 26, 2018
@jhawthorn jhawthorn changed the title Splitted shipment should update order totals/payment status Splitting shipment should update order totals/payment status Mar 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants