Fix bug with user address forms #2766
Conversation
Add Stock Location Address functionality to User Address
There was a problem hiding this comment.
I don’t understand why renaming a file and a css class fixes the issue you are refering to.
Could you please provide some more background on how to reproduce the issue in the sandbox and why your fix works? The commit message is unfortunately not very helpful either.
Thanks
|
Hey @tvdeyen, thanks for the quick review. The issue occurs in the backend when updating a user's address information. When the country is changed, the states collection does not update. See #2519 for a screenshot of the issue. You can see the behavior in the sandbox app or any vanilla solidus app at Existing code in We changed the name of the JS file and the CSS class name to reflect an increase in usage. It is now being used in Let me know if there are any other changes needed. |
|
@tvdeyen Agreed! Change made. Thanks for the speedy responses! |
| @@ -3,7 +3,7 @@ | |||
| Spree.ready(function() { | |||
| "use strict"; | |||
|
|
|||
| _.each(document.querySelectorAll('.js-stock-locations-form'), function(el) { | |||
| _.each(document.querySelectorAll('.js-locations-form'), function(el) { | |||
There was a problem hiding this comment.
Could we also rename the class to js-addresses-form?
There was a problem hiding this comment.
@tvdeyen Good idea! Change made. Thanks!
|
@tvdeyen @kennyadsl just curious, is there anything else we need to do on this PR? |
|
No I think we just need to merge, doing it now! |
|
@kennyadsl Thank you! |
refs #2519
Bug: states would not reload with change in country on user address forms
Stock Location JS solved this for stock location forms so it was renamed and used in user address forms.
Notes: Considering this change a refactor so no new tests were added. Let me know if tests should be written.