Fix reference to logo on heroku template #2896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvdeyen
reviewed
Oct 5, 2018
chukitow
force-pushed
the
hotfix/fix-reference-to-logo-on-heroku-template
branch
from
3f58e81
to
11bdeaa
Compare
ericsaupe
approved these changes
Oct 11, 2018
chukitow
force-pushed
the
hotfix/fix-reference-to-logo-on-heroku-template
branch
from
11bdeaa
to
eb30b12
Compare
|
I just rebased but not sure why there are some errors in the tests 🤔 |
|
@chukitow we are having issues with circle right now! Might not be your code. |
|
Looks like conflicts where resolved @jacobeubanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you attempt to create a solidus app using the one click installer the logo is missing
I updated the logo path to use the one you have on your website, I guess thats the one you were using before.