Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add padding to the order summary #2903

Merged
merged 1 commit into from Oct 12, 2018
Merged

Add padding to the order summary #2903

merged 1 commit into from Oct 12, 2018

Conversation

jacobherrington
Copy link
Contributor

This change aligns the order summary heading to the subheadings

Before
screen shot 2018-10-07 at 5 07 54 pm

After
screen shot 2018-10-07 at 5 08 30 pm

Add padding to the order summary
ca3227b 
This change aligns the order summary heading to the subheadings
ericsaupe
ericsaupe approved these changes Oct 11, 2018
View reviewed changes
Copy link
Contributor

@ericsaupe ericsaupe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I know a lot of people completely override the frontend but having a good looking default is important.

@jacobherrington
Copy link
Contributor Author

@ericsaupe I agree, something I've been meaning to go back and work on more but haven't had the time. Thanks for the review!

kennyadsl
kennyadsl approved these changes Oct 11, 2018
View reviewed changes
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That h1 is also useless, the information is duplicated immediately above but, as already stated, this is meant to be replaced so 👍

@tvdeyen tvdeyen merged commit b089fdb into solidusio:master Oct 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennyadsl kennyadsl kennyadsl approved these changes

@ericsaupe ericsaupe ericsaupe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jacobherrington @kennyadsl @ericsaupe @tvdeyen