Fix deprecations to make Solidus work with Rails 5.2.2 #2992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were missing an alias_method here. Some code changed in Rails and now it correctly raises an exception since this old method, that has been removed, is not found.
deprecate method takes a list of methods so current code is actually deprecating a method named: "Spree::Store.by_url is DEPRECATED". For some reason this code was working until Rails 5.2.1
This reverts commit 6ad412f. This should not be needed anymore since wrong deprecation calls has been fixed.
kennyadsl
changed the title
This was referenced Dec 6, 2018
ericsaupe
approved these changes
Dec 6, 2018
|
Not sure what Hound wants here 🐶 |
kennyadsl
added a commit
to solidusio-contrib/solidus_related_products
that referenced
this pull request
Dec 13, 2018
We don't need anymore to lock this extension to Rails 5.2.1 since solidus core is now compatible with it. ref solidusio/solidus#2992
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a couple of wrong calls of
deprecatemethod. These errors are raising errors from Rails5.2.2since this PR has been merged.This PR is also reverting the
5.2.1lock of Rails version.Unfortunately, if this works, I think we should also apply these fixes to Solidus
v2.6andv2.7otherwise Rails5.2.2cannot be used by users that use those versions via RubyGems.