Deprecate 'X-SPREE-TOKEN' header 2 #3029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twist900
changed the title
twist900
force-pushed
the
twist900/authorization-header
branch
from
c94fb91
to
33b020b
Compare
kennyadsl
reviewed
Jan 9, 2019
There was a problem hiding this comment.
Left a code formatting comment, but overall it's a great work.
I'm also not sure if it's better to squash commits since git looking at the last commit alone outside this PR could look like we are adding the spree_token into an already existing bearer_token instead of the opposite. What do you think?
| end | ||
| helper_method :api_key | ||
|
|
||
| def bearer_token | ||
| pattern = /^Bearer / | ||
| header = request.headers["Authorization"] |
There was a problem hiding this comment.
I'd remove one space after header, it's aligned to pattern on the line above but if that line changes in the future we'll be forced to change this one as well and this is not ideal for git history. What do you think?
twist900
force-pushed
the
twist900/authorization-header
branch
from
33b020b
to
41a30ee
Compare
Move from custom X-Spree-Token header to Authorization header. Keep support of the deprecated X-Spree-Token header for backward compatibility.
twist900
force-pushed
the
twist900/authorization-header
branch
from
41a30ee
to
88068cb
Compare
kennyadsl
approved these changes
Jan 12, 2019
ericsaupe
approved these changes
Jan 16, 2019
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a continuation of #2996. It keeps the X-SPREE-TOKEN alongside the newly introduced bearer authorization token for backward compatibility. A deprecation message is displayed when the X-SPREE-TOKEN header is detected.
Also, it fixes some linting issue.
ref #2934
Checklist: